Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from lark-parser to lark #82

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

NolanTrem
Copy link
Collaborator

This PR replaces lark-parser with lark in order to simplify dependency management and avoid the conflicts that arise when a project (or its sub-dependencies) ends up installing both packages into the same site-packages/lark/ directory.

lark-parser is no longer maintained, and has been replaced by lark, which makes it extremely difficult to work with both now.

Addresses #77

See the following for more details of what this looks like upstream:
lark-parser/lark#1511 (comment)
SciPhi-AI/R2R#1929

Copy link

linux-foundation-easycla bot commented Feb 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@kapilt kapilt merged commit 87c3cf3 into cloud-custodian:main Feb 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python 3.8 from github workflow. It's beyond end-of-life and any tests using it tend to fail.
2 participants